Add routing to application #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswallace
requested review from
SeanLeRoy,
kmitcham,
pgarrison and
BrianWhitneyAI
kmitcham
approved these changes
May 15, 2024
kmitcham
approved these changes
May 15, 2024
pgarrison
approved these changes
May 20, 2024
BrianWhitneyAI
approved these changes
May 20, 2024
…e/aics-fms-file-explorer-app into feature/add-routing-to-web
|
Branch got into rebase nightmare land; closing in favor of opening the splash page PR #107 which incorporates the same changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
react-routerv6 to the web app so that we will be able to have a separate route for the splash page"/"currently routes to a blank placeholder page"/app"routes to the actual appTesting
Tested manually. As of opening this PR, have not yet added unit tests for the router. Unit tests and linting are currently failing, but seem to be unrelated to these changes.
closes #95