Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ceiling on Pillow; adjust default reader expectations #543

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

SeanLeRoy
Copy link
Collaborator

With the release of imageio 2.28.0 on 04/23/2023, main[base-imageio] failed when using imageio's pillow plugin to access images. As a result of this we pinned 2.27.0. In 2.31.0 it seems this issue was resolved, so this adjusts the versions.

Note It seems instead of RGBA imageio now returns RGB for gifs? Unsure if we want to do some more investigation before merging this.

@SeanLeRoy SeanLeRoy self-assigned this Nov 9, 2023
@SeanLeRoy SeanLeRoy linked an issue Nov 9, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c097bd) 93.99% compared to head (412c3a1) 93.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   93.99%   93.97%   -0.03%     
==========================================
  Files          53       53              
  Lines        4662     4662              
==========================================
- Hits         4382     4381       -1     
- Misses        280      281       +1     
Files Coverage Δ
...tests/readers/extra_readers/test_default_reader.py 100.00% <ø> (ø)
...ts/writers/extra_writers/test_timeseries_writer.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeanLeRoy SeanLeRoy marked this pull request as ready for review November 9, 2023 17:58
Copy link
Collaborator

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know if any users will have trouble with the more restrictive constraint here but I don't think this reader is really used all that much. I hope.

Are the unit test changes due to actual changes in the way imageio behaves? I believe GIF supports only binary transparency but not an alpha channel.

@SeanLeRoy
Copy link
Collaborator Author

Are the unit test changes due to actual changes in the way imageio behaves?

Yes, I believe so

@SeanLeRoy SeanLeRoy merged commit cd5a50c into main Nov 20, 2023
92 checks passed
@SeanLeRoy SeanLeRoy deleted the admin/remove-cap-on-imageio branch November 20, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main[base-imageio] failing due to Pillow
4 participants