Adjust bfio & fsspec versions to avoid bugs #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
force-pushed
the
bugfix/bfio-2.3.0-issues
branch
from
67ce3d9 to
e0e79a4
Compare
SeanLeRoy
force-pushed
the
bugfix/bfio-2.3.0-issues
branch
from
e0e79a4 to
9ffe224
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
===========================================
- Coverage 89.55% 68.23% -21.33%
===========================================
Files 53 53
Lines 4662 4662
===========================================
- Hits 4175 3181 -994
- Misses 487 1481 +994
☔ View full report in Codecov by Sentry. |
SeanLeRoy
changed the title
BrianWhitneyAI
approved these changes
Oct 27, 2023
kmitcham
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes 2 bugs and a lint issue
fsspec bugfix
The SLDY reader uses the
glob()function offsspecwhich seems to be buggy after version2023.9.0, limiting the version until a resolution to the corresponding fsspec issue is reachedbfio bugfix
bfioversions 2.3.1 & 2.3.2 (AKA every version > 2.3.0) seem to leave a file open when it seems they used to automatically close. I didn't catch a change to the API/contract inbfiothat suggest that this should happen and to manually close it. Hoping that this will be removed in 2.4.0 hence the weird version selection.