Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pydantic import #535

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Adjust pydantic import #535

merged 1 commit into from
Oct 18, 2023

Conversation

SeanLeRoy
Copy link
Collaborator

Description

Should resolve #534 where Pydantic is reporting that ValidationError moved locations

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e3d0ad) 89.54% compared to head (3e43be2) 89.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          53       53           
  Lines        4658     4658           
=======================================
  Hits         4171     4171           
  Misses        487      487           
Files Coverage Δ
aicsimageio/readers/ome_tiff_reader.py 90.98% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BrianWhitneyAI BrianWhitneyAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward. Nice work!

@SeanLeRoy SeanLeRoy merged commit e12198a into main Oct 18, 2023
97 of 122 checks passed
@SeanLeRoy SeanLeRoy deleted the feature/avoid-pydantic-warning branch October 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic user warning on import
4 participants