Fix wilms-06 typos #885
Merged
Fix wilms-06 typos #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fects the sessioninfo
sjspielman
requested review from
jaclyn-taroni
and removed request for
jaclyn-taroni
jaclyn-taroni
approved these changes
Nov 15, 2024
.github/components/dictionary.txt
Outdated
| scrublet | ||
| SEACells | ||
| SemVar | ||
| seq | ||
| SingleR | ||
| snRNA | ||
| socio | ||
| spearman |
There was a problem hiding this comment.
A proper noun, so does this belong here?
There was a problem hiding this comment.
Yes, it will still need to be in the dictionary, but it should be uppercase for sure.
analyses/cell-type-wilms-tumor-06/notebook_template/06_cnv_infercnv_exploration.Rmd
Outdated
Show resolved
Hide resolved
|
Thank you for catching these!! I will proper noun-ify Spearman, very good point. |
Co-authored-by: Jaclyn Taroni <[email protected]>
sjspielman
merged commit 59d0d79
into
AlexsLemonade:feature/wilms-tumor-06-azimuth
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1/3 for #883
Also partially takes care of #882
This PR fixes typos across the module.
After fixing typos, I regenerated the following notebooks:
00b_characterize_fetal_kidney_reference_Stewart.nb.html04_annotation_Across_Samples_exploration_predicted.score_threshold_*.html07_combined_annotation_across_samples_exploration.htmlI did not regenerate notebooks for:
02b_label-transfer_fetal_kidney_reference_Stewart.Rmd03_clustering_exploration.Rmd05_copykat_exploration.Rmdand06_cnv_infercnv_exploration.Rmd. We anticipate circling back to these later either way, see Regenerate or move wilms-06 module exploratory CNV notebooks #875For
02band03notebooks, there were very few typos, so I didn't think regenerating these was urgent. Maybe we can tack these into #875 too, or open a separate issue to regenerate them. But, since the substantive results don't really change, it probably doesn't hurt that the HTMLs are out of date. If you have any opinions here please let me know!