-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wilms-06 update CNV methods: infercnv (2/3) #873
Merged
sjspielman
merged 4 commits into
AlexsLemonade:feature/wilms-tumor-06-azimuth
from
sjspielman:sjspielman/wilms-06_update-infercnv
Nov 12, 2024
Merged
Wilms-06 update CNV methods: infercnv (2/3) #873
sjspielman
merged 4 commits into
AlexsLemonade:feature/wilms-tumor-06-azimuth
from
sjspielman:sjspielman/wilms-06_update-infercnv
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
changed the title
Wilms-06 update CNV methods (2/3)
Wilms-06 update CNV methods: infercnv (2/3)
Nov 11, 2024
sjspielman
changed the base branch from
main
to
feature/wilms-tumor-06-azimuth
November 11, 2024 16:12
sjspielman
commented
Nov 11, 2024
@@ -138,8 +167,6 @@ counts <- GetAssayData(object = srat, assay = "RNA", layer = "counts") | |||
annot_df <- data.frame(condition = as.character(srat$fetal_kidney_predicted.compartment)) | |||
rownames(annot_df) <- colnames(counts) | |||
|
|||
|
|||
# We only run the CNV HMM prediction model if the reference is "both" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this comment was removed because it is not accurate.
jaclyn-taroni
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
…6_update-infercnv
sjspielman
merged commit Nov 12, 2024
a082fb3
into
AlexsLemonade:feature/wilms-tumor-06-azimuth
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #810
This is the secodn of three PRs which update the CNV-related steps of the
cell-type-wilms-tumor-06
module. This PR both updates the06_copykat.R
script and06_infercnv_exploration.Rmd
notebook.06_infercnv.R
script as follows:score_threshold
06_infercnv_exploration.Rmd
The third PR will be filed once #872 is merged, since it will update code in the
explore-cnv-methods.sh
script which that PR established to use the new testing flag in06_infercnv.R
added here.In addition, the third PR may need to somehow update the rendered
html
notebooks for the exploratory copykat and infercnv code which are stored, for the 5 explored samples innotebook/{sample_id}/
. I cannot fully render these notebooks (though I confirmed they run with test data!) due to compute limitations, so I see these as the best two ways to handle them:results
instead, since they are not part of the actual annotation pipeline. In this case, I would take those steps in the third PR.main
. In this case, I would file an issue for followup.