Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wilms-06 update CNV methods: infercnv (2/3) #873

Conversation

sjspielman
Copy link
Member

Towards #810

This is the secodn of three PRs which update the CNV-related steps of the cell-type-wilms-tumor-06 module. This PR both updates the 06_copykat.R script and 06_infercnv_exploration.Rmd notebook.

  • I updated the 06_infercnv.R script as follows:
    • I made sure we actually use the threshold for identifying normal cells to use in the reference via the new argument score_threshold
    • I added a flag which can be used in CI testing. When run in CI, this script will attempt to use a reference set of normal cells, but we can't expect that the testing data actually has normal cells. So, turning on this flag will ensure no reference is used when the test data is used.
  • I fixed a small bug in 06_infercnv_exploration.Rmd

The third PR will be filed once #872 is merged, since it will update code in the explore-cnv-methods.sh script which that PR established to use the new testing flag in 06_infercnv.R added here.

In addition, the third PR may need to somehow update the rendered html notebooks for the exploratory copykat and infercnv code which are stored, for the 5 explored samples in notebook/{sample_id}/. I cannot fully render these notebooks (though I confirmed they run with test data!) due to compute limitations, so I see these as the best two ways to handle them:

  • We can actually potentially remove these notebooks from the repo and send them to results instead, since they are not part of the actual annotation pipeline. In this case, I would take those steps in the third PR.
  • We can probably ask Maud to regenerate these notebooks once we merge all this code into main. In this case, I would file an issue for followup.

@sjspielman sjspielman changed the title Wilms-06 update CNV methods (2/3) Wilms-06 update CNV methods: infercnv (2/3) Nov 11, 2024
@sjspielman sjspielman changed the base branch from main to feature/wilms-tumor-06-azimuth November 11, 2024 16:12
@@ -138,8 +167,6 @@ counts <- GetAssayData(object = srat, assay = "RNA", layer = "counts")
annot_df <- data.frame(condition = as.character(srat$fetal_kidney_predicted.compartment))
rownames(annot_df) <- colnames(counts)


# We only run the CNV HMM prediction model if the reference is "both"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this comment was removed because it is not accurate.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sjspielman sjspielman merged commit a082fb3 into AlexsLemonade:feature/wilms-tumor-06-azimuth Nov 12, 2024
3 checks passed
@sjspielman sjspielman deleted the sjspielman/wilms-06_update-infercnv branch November 12, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants