-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculate_stability usage #871
Update calculate_stability usage #871
Conversation
I did retrigger this run after the |
Environment indeed seems to be cached. Let's just re-trigger after the weekend! |
Still mostly cached, but there was this line which makes me think
|
Did you update |
Ah, I had assumed since we didn't do release/tag (though, we probably need to adopt a |
I don't think that we do, at least not at this time. |
When I snapshot'ed |
@@ -2076,8 +2372,8 @@ | |||
"RemoteHost": "api.github.com", | |||
"RemoteUsername": "AlexsLemonade", | |||
"RemoteRepo": "rOpenScPCA", | |||
"RemoteRef": "main", | |||
"RemoteSha": "fc784446f8d86b072e6f7f67287adfff598f4911", | |||
"RemoteRef": "f71a8191130fa543e6506c73c7b62ffa55e8ba3f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make this update manually, installing the commit directly? I would have expected the RemoteRef
to stay as main
, which will enable future updates with just renv::update("rOpenScPCA")
. Otherwise we have to keep track of the hashes much more manually, which is annoying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did renv::install("rOpenScPCA@......")
. Will go again with update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to just change these lines manually.
"RemoteRef": "f71a8191130fa543e6506c73c7b62ffa55e8ba3f", | |
"RemoteRef": "main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #870
Pretty much does what it says, following AlexsLemonade/rOpenScPCA#4!
Files were styled by pre-commit, too.