Wilms 06 module: Update and re-render 04 notebook #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #810
This PR updates the next step in the wilms-06 module, the
04_annotation_Across_Samples_exploration.Rmd
notebook. Changes include:00_run_workflow.sh
script to include all remaining workflow stepsif [[ $IS_CI -eq 0 ]]; then
will be removed in the next PR (details below), but the code there should be ready to go to run it through CI.Here's what to expect next:
scripts/explore-cnv-methods.R
into a shell script, since this currently usessystem()
to call other R commands, and we've seen that is not a robust strategy to ensure the whole script fails if a step fails.04
notebook in this PR to look at thresholds for using scores, and then we proceeded not to actually use those thresholds 🤦♀️ . Cells used as normal reference need to meet the threshold! There are also several samples which do not have any cells to use as a normal reference, so these will be run through the workflow without a reference.