-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
celltype/tumor annotation for non-ETP T-ALL (SCPCP000003) #788
celltype/tumor annotation for non-ETP T-ALL (SCPCP000003) #788
Conversation
Hi @UTSouthwesternDSSR, I wanted to answer your question before a full review:
We will look at the results during the review of the PR. |
@UTSouthwesternDSSR, it looks like we're in an excellent position to start testing this module. I will commit some changes to this branch to get it up and running so we'll be aware of any errors during the review. |
Hi @UTSouthwesternDSSR, it looks like you initialized a new module starting at 4396373. My assumption here is that you accidentally committed to this branch instead of a new one. Can we revert back to cd02ec1 so we can keep the review focused on the non-ETP-ALL module? One way would be to start a new branch at that commit and open a new PR. Please let me know if you have questions or if there's any way we can help! Thank you. |
Sorry about this! Yeah, I meant to create a new module for ETP-ALL. Could you please guide me how to revert back to "minor update on script"? I will try to open a new branch now. |
Happy to help! You should be able to create a new branch from that commit with the following command: git branch {new branch name} cd02ec127f6c5bd3a3772c3f1e2f264eb936b86b Replacing # Checkout the branch
git checkout {new branch name}
# Push it to origin
git push -u origin HEAD You could then create a new PR and close this one. You can just copy and paste exactly what you wrote in your initial comment here. |
This is what I did:
But it gives above error. I am not sure if I am doing it wrong? |
Actually I am a bit confused. It seems like it did work. On my github webpage, there are two branches I have another question. I am trying to download the |
Since you got this error when pushing to GitHub: I would not expect the If you're using GitKraken, you can check out the If you want to use the command line, you'll need to generate a Personal Access Token (GitHub docs: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) and use it in your password field instead of your actual password. This is because multifactor authentication is on.
When cloning, you'll first be on the You can continue to develop the ETP module in this branch ( Please let me know if you have any more questions. |
Purpose/implementation Section
The goal of this PR is to annotate cell types with ScType and identify tumor cells with CopyKat using the annotated B cells in the same sample (if there is any).
Please link to the GitHub issue that this pull request addresses.
What is the goal of this pull request?
Annotate cell types with ScType and identify tumor cells with CopyKat using the annotated B cells in the same sample (if there is any).
Briefly describe the general approach you took to achieve this goal.
If known, do you anticipate filing additional pull requests to complete this analysis module?
Out of 11 samples, 7 samples have B cells annotated (except SCPCS000091, SCPCS000092, SCPCS000098, and SCPCS000100). Although SCPCS000099 contains B cells, these cells are not useful for the identification of tumor cells, as shown by the extremely large number of not.defined cells with default parameters.
I may try to merge the samples, and use the annotated B cells as the normal cell to run CopyKat, hoping that we could identify tumor cells from those samples without B cells. This could be another pull request, if it works.
Results
What is the name of your results bucket on S3?
rds
objects are found ins3://researcher-650251722463-us-east-2/cell-type-nonETP-ALL-03/results/rds
s3://researcher-650251722463-us-east-2/cell-type-nonETP-ALL-03/results/
s3://researcher-650251722463-us-east-2/cell-type-nonETP-ALL-03/plots
What types of results does your code produce (e.g., table, figure)?
rds
objects_metadata.txt
(cell ID, leiden clusters, cell type annotation, low confidence cell type annotation, CopyKat prediction [for the 7 samples]) and_sctype_top10_celltypes_perCluster.txt
(top 10 possible cell types with their respective sctype score in each cluster)umap
plots showing leiden clustering, cell type, and CopyKat prediction respectivelydot
plots showing the average expression of group of markers for each cell type usingAddModuleScore()
What is your summary of the results?
With the default threshold of having sctype score > 25% of ncells in a cluster (
sctype_classification
), there are a large number of cells being annotated as "Unknown" in each sample, reaching to as high as ~45% (disregarding SCPCS000099: 48% and SCPCS000100: 52%, which have much lower number of features detected).Therefore, I relaxed the threshold from 25% to 10% (
lowConfidence_annot
), and the percentage of "Unknown" is now dropped to 30% (disregarding SCPCS000099: 33% and SCPCS000100: 48%), with 5 samples having no "Unknown".I only ran CopyKat for 7 samples, excluding SCPCS000091, SCPCS000092, SCPCS000098, and SCPCS000100. However,
tumor prediction does not work for SCPCS000099, given that it has 36% of "not.defined", while the other samples have less than 1%. Even if I relaxed the cutoff of ngene.chr from 5 to 1, the number of "not.defined" cells decreases, but they all get annotated as "diploid".
Provide directions for reviewers
What are the software and computational requirements needed to be able to run the code in this PR?
renv.lock
andconda.lock
Are there particularly areas you'd like reviewers to have a close look at?
Is there anything that you want to discuss further?
Thank you so much for any suggestions/feedback!
Author checklists
Check all those that apply.
Note that you may find it easier to check off these items after the pull request is actually filed.
Analysis module and review
README.md
has been updated to reflect code changes in this pull request.Reproducibility checklist
Dockerfile
.environment.yml
file.renv.lock
file.