Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to perform graph-based clustering #749
Add function to perform graph-based clustering #749
Changes from 38 commits
5fba017
116c73d
3ad4f49
8df9716
5eff758
3812826
f4b2337
0305faa
f6b736d
148ae00
5b48321
29c7868
15fea48
b168a01
0a433b8
288842a
ed93f85
d7abb39
e4bf3de
3498350
9db71da
d576509
52fd2d1
c11cedc
e35bdf6
b724ebb
33127ae
4d1a91f
4daa7e5
835b7ee
d8f5b31
329180d
37d4973
662c33f
fe022d5
7075b17
c89e3b9
e536f02
bcc9254
d904171
0cdfe03
e7b22cc
b2b4cbe
b0a9065
9a8a4b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually leave off the explanation here. Instead, I was suggesting a paragraph of explanation before the
@params
, which will end up in the function description.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep
walktrap
as the default for consistency with the underlying package?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel really torn about this actually (and similarly the weighting param re-order)... I agree about consistency with bluster, but it makes me nervous since these defaults don't correspond to the way most people will want to use the functions (...aka seurat defaults) so it seems potentially less user-friendly. On the other hand this would force folks to be explicit, which is a good thing!
Please give me a further push to be convinced to accept this 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a very strong preference, aside from that if you change the defaults from the underlying method that should be made explicit in the docs. In particular, I would add a description after the roxygen heading explaining the motivation for this function and the way it differs from the bluster default/underlying implementation.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.