-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiate ropenspca package #735
Initiate ropenspca package #735
Conversation
Co-authored-by: Stephanie Spielman <[email protected]>
Co-authored-by: Joshua Shapiro <[email protected]>
This reverts commit 2bb9755.
This reverts commit 8a550aa.
If |
…/fix-typo Custom function in ipynb should talk about AnnData
I think I would start this without |
with: | ||
extra-packages: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to specify the directory here. (And you should not need to specify testthat
as that is part of the DESCRIPTION)
with: | |
extra-packages: | | |
with: | |
working-directory: "packages/rOpenScPCA/" | |
extra-packages: | |
…/docker-build-big-disk Run Docker build and push on a larger runner
…/OpenScPCA-analysis into sjspielman/708-module-styling
This reverts commit 0e51c5a.
Co-authored-by: Joshua Shapiro <[email protected]>
…odule-styling Update code styling workflow
Co-authored-by: Joshua Shapiro <[email protected]>
…orkflow-readme Add README for github workflows directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but we do want it to pass all the checks.
packages/rOpenScPCA/DESCRIPTION
Outdated
Maintainer: Stephanie J. Spielman <[email protected]> | ||
Description: This package contains utility functions that support single-cell RNA-seq | ||
analysis in R-based OpenScPCA analysis module code. | ||
License: BSD_3_clause + ../../LICENSE file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax is + file LICENSE
so that could be part of the error, but the location seems like a likely culprit as well.
To quiet this error, I would probably just copy the license file into the package.
We'll probably end up wanting to skip some other checks too (we don't need strict CRAN compliance), but we can cross that bridge later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To quiet this error, I would probably just copy the license file into the package.
👍
Co-authored-by: Joshua Shapiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #732
This PR initiates the directory for the
rOpenScPCA
package. Some notes:R CMD CHECK
the package, and a temporary function to test as part of that to make sure it works.renv
to track packages used during package development. For now, I've includedrenv
, but I'm not really tied to keeping it. What do you think?DESCRIPTION
how's my syntax for referencing the repo's top-level LICENSE file? Surprising nobody,devtools::check()
gives it aWARNING
, but could be ok for this circumstance?