-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rosetta to Docker installation instructions #694
Add Rosetta to Docker installation instructions #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I think I might add "Use containerd for pulling and storing images" as well. Not sure when multiplatform images might come up, but they might and it would be nice not to have to revise this then.
I also might add a reference to Rosetta where we talk about the --platform
option. Maybe a link back to this section?
docs/ensuring-repro/docker/index.md
Outdated
|
||
After installing Docker, we recommend that Apple silicon Mac users follow these additional steps: | ||
|
||
1. Install Rosetta 2 [as described in the "System Requirements" section in the "Mac with Apple Silicon" tab](https://docs.docker.com/desktop/install/mac-install/#system-requirements). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since people have to click a tab to get the instructions, maybe just tell them to install directly with softwareupdate --install-rosetta
in a terminal window.
But if you keep this, note that on the web page it is ""Mac with Apple silicon"
Can you clarify this? Are you asking for an additional section here, or something like linking to this from |
No - spellcheck got me - I thought you had a typo! |
Co-authored-by: Joshua Shapiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 one change I'd like to see before merging
Co-authored-by: Jaclyn Taroni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed #689
This PR adds documentation that Apple silicon users should enable Rosetta when installing and setting up Docker Desktop. Let me know if we want a screen shot here or any additional info.