Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rosetta to Docker installation instructions #694

Merged

Conversation

sjspielman
Copy link
Member

Closed #689

This PR adds documentation that Apple silicon users should enable Rosetta when installing and setting up Docker Desktop. Let me know if we want a screen shot here or any additional info.

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

I think I might add "Use containerd for pulling and storing images" as well. Not sure when multiplatform images might come up, but they might and it would be nice not to have to revise this then.

I also might add a reference to Rosetta where we talk about the --platform option. Maybe a link back to this section?

docs/ensuring-repro/docker/index.md Outdated Show resolved Hide resolved
docs/ensuring-repro/docker/index.md Outdated Show resolved Hide resolved

After installing Docker, we recommend that Apple silicon Mac users follow these additional steps:

1. Install Rosetta 2 [as described in the "System Requirements" section in the "Mac with Apple Silicon" tab](https://docs.docker.com/desktop/install/mac-install/#system-requirements).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since people have to click a tab to get the instructions, maybe just tell them to install directly with softwareupdate --install-rosetta in a terminal window.

But if you keep this, note that on the web page it is ""Mac with Apple silicon"

@sjspielman
Copy link
Member Author

think I might add "Use containers for pulling and storing images" as well.

Can you clarify this? Are you asking for an additional section here, or something like linking to this from using-images.md or so?

@jashapiro
Copy link
Member

think I might add "Use containers for pulling and storing images" as well.

Can you clarify this? Are you asking for an additional section here, or something like linking to this from using-images.md or so?

No, just suggesting people activate that option as well. But spellcheck got me. It should be "Use containerd for pulling and storing images"
Screenshot 2024-08-05 at 4 55 34 PM

@sjspielman
Copy link
Member Author

But spellcheck got me. It should be "Use containerd

No - spellcheck got me - I thought you had a typo!

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 one change I'd like to see before merging

docs/ensuring-repro/docker/using-images.md Outdated Show resolved Hide resolved
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjspielman sjspielman merged commit 1e22909 into AlexsLemonade:main Aug 6, 2024
4 checks passed
@sjspielman sjspielman deleted the sjspielman/689-docker-rosetta branch August 6, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker setup instructions for Mac
3 participants