-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wallet connection and chainStorageWatcher #63
Conversation
- there was a regression in #57 that broke `makeAgoricChainStorageWatcher` - it needs to take an apiUrl instead of rpc - `makeAgoricWalletConnection` needs an rpc to work, and an api endpoint, so this change brings it up to date with the new @agoric/rpc changes
P.S. if you are testing manually, Revisiting efforts to fix that upstream: Agoric/agoric-3-proposals#73 |
...
any particular reason? I thought separating them was on purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it can't hurt.
API: 'http://localhost:1317', | ||
}; | ||
|
||
const watcher = makeAgoricChainStorageWatcher(ENDPOINTS.API, 'agoriclocal'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's hoping for
It's my interpretation after reading this article. When I was updating the |
I don't think we want to use code from the contract package in the UI nor vice versa. And I'm pretty sure we want to be able to use new shiny stuff in the ui before issues that would complicate compatibility between the contract and the chain get addressed. But I'm OK dealing with all that outside this PR. |
In yarn classic I believe there's a nohoist key that can be parameterized in |
makeAgoricChainStorageWatcher
- it needs to take an apiUrl instead of rpcmakeAgoricWalletConnection
needs an rpc to work, and an api endpoint, so this change brings it up to date with the new @agoric/rpc changesyarn.lock
in the workspaceTested manually as it'd be a bit of work to add testing with keplr. A more cost effective test in the interim could be a UI banner that shows if the instance was found (API only), and a test to see if it's present. That would validate
chainStorageWatcher
is working (and, the contract install). Edit: Seem something to this effect is tracked here: #46