feat: ui improvements #25
Conversation
ui/src/components/Trade.tsx
Outdated
| import { FormEvent, useState } from 'react'; | ||
| import { stringifyAmountValue } from '@agoric/ui-components'; | ||
| import scrollIcon from '../assets/scroll.png'; | ||
| import istIcon from '../assets/IST.png'; |
| <div className="row-center"> | ||
| <Item | ||
| key="IST" | ||
| coinIcon={istIcon} |
There was a problem hiding this comment.
My eye very much expects fungibles to be written horizontally: 10 USD. 5 IST.
stacking IST on top of the logo seems awkward.
There was a problem hiding this comment.
Agree, maybe a ticket to use <NatInput /> is worthwhile. But I'm not sure if that comes with styling.
I'd like to see how it looks with the give / want side by side. Is it obvious to you how to do that? |
Changing the UI makes it inconsistent with the docs, including the video walkthru. So it's not clear that we want to land lots of little improvements - do we update the docs and video each time? Having product make a conscious decision about whether this is the next update seems cost-effective. |
@sufyaankhan says go. |
0xpatrickdev
force-pushed
the
pc/ui-add-prettier
branch
from
305cb84 to
ed60c87
Compare
refactor: split into components
feat(ui): improve styling
fix: wallet connection and chainStorageWatcher #63 should be merged in first
Still room for improvement, ideally the user shouldn't have to scroll, but I think this looks a little bit better: