refactor: modernize @endo/errors @agoric/store imports

[erights]

closes: #XXXX
refs: #8771

Description

Now that a recent endo is released and agoric-sdk has been upgraded to depend on it, we can finally get to a lot of agoric-sdk technical-debt cleanups that we've postponed. The cleanups in this PR include:

• Directly importing many things from endo, rather than obsolete agoric-sdk re-exporters
• Switching many uses of assert from the global or @agoric/assert package to its successor @endo/errors.

There's one trivial semantic change in switching many asserts to @endo/errors. Unlike the global assert or the assert exported by @agoric/assert, the assert object as exported by @endo/errors does not have non-asserting methods like note (aka errorNote) or error (aka makeError). Thus, when these were called as methods on assert, I had to import the functions directly, and then change the code to call the function, rather than making a method call. Other than that, this PR should have very little aside from changing imports and a few reexports + the package.json changes needed to depend on those endo packages.

Extracted from #8771 per #8771 (comment) but made into a separate PR so it can be merged or not on its own.

Also includes @turadg 's fix to the casting maxNodeModuleJsDepth from #8771

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

none

Upgrade Considerations

@ivanlei , I added you for feedback on when it would not be too disruptive to merge this. That's another reason to separate it into a PR distinct from the remaining changes in #8771 . By minimizing the non-import-export code changes, it shouldn't much hurt our ability to cherry pick.

[turadg]

This pattern is what I was trying to get away from with making a package at all. There's no export of Fail so there's no autocomplete when someone wants to import Fail.

q and Fail are the convention in this repo, so they should have exports. I propose @agoric/errors assert continue to export those.

The other changes in the PR look good. I'd have accepted without the errors changed. That's one of the good reasons to separate commits. E.g. refactor: modernize @agoric/store imports and separately refactor: modernize errors imports. Then we could easily pick which changes to include.

Incidentally, how did 6e0290e turn into a49db10 ? Why not simply cherry-pick it?

[turadg]

Incidentally, the plan of record is for @agoric/assert to itself import @endo/errors,

• migrate to @endo/errors package #5672