Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 8771 simplifications without 8781 import reforms #8782

Closed
wants to merge 2 commits into from

Conversation

erights
Copy link
Member

@erights erights commented Jan 21, 2024

closes: #XXXX
refs: #8771 #8781

Description

#8771 is staged on #8781 , under the assumption that #8781 would be merged first. But they're mostly independent. In case the changes from #8771 should get merged first, this PR adds to those changes another small commit to compensate for the absence of #8781.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights requested review from turadg and ivanlei January 21, 2024 03:10
@erights erights self-assigned this Jan 21, 2024
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8771 is staged on #8781 , under the assumption that #8781 would be merged first. But they're mostly independent

I don't see it staged. The base branch is master. It's passing checks so it is indeed independent.

However the fix: compensate for lack of 8781 prevent this from being merged as is. For one, the conventional commits show up in the changelog and commit is irrelevant to any consumer of the package. There's nothing being fixed that has been released. It's "fixing up" the refactor commit to make it work, which should just be part of the refactor commit.

Separately, the removal of the same-structure package is not itself a refactor. Basically we're freezing the NPM-published @agoric/same-structure because it won't ever be published again. As part of landing this, someone should deprecate the published package.

@erights erights force-pushed the markm-try-8771-without-8781 branch from f8dc48d to e2356bc Compare January 26, 2024 01:57
@erights
Copy link
Member Author

erights commented Jan 26, 2024

Closed in favor of #8771

@erights erights closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants