refactor: stateShape causes accessor sharing #7444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-state-proto-2
branch
from
676b201 to
ea21995
Compare
erights
force-pushed
the
markm-vom-readability-only
branch
from
c583f3f to
c3a84c5
Compare
erights
force-pushed
the
markm-state-proto-2
branch
from
ea21995 to
2c1ae07
Compare
erights
force-pushed
the
markm-state-proto-2
branch
from
2c1ae07 to
bc3075d
Compare
erights
changed the title
This was referenced Apr 18, 2023
erights
force-pushed
the
markm-state-proto-2
branch
from
4a086ce to
693d00b
Compare
erights
force-pushed
the
markm-state-proto-2
branch
2 times, most recently
from
7ee043d to
b514d4b
Compare
FUDCo
approved these changes
Apr 18, 2023
erights
force-pushed
the
markm-state-proto-2
branch
from
b514d4b to
f264d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive #7286
Staged on #7443
When a kind is provided with a
stateShape, we know exactly what the names are for all of thestatefields across all instances. For that case, it is wasteful to create accessor properties per instance. So instead, when there is astateShape, this PR will instead install similar accessors on a sharedstatePrototypeobject. Eachstateobject is then a frozen empty object that inherits from thatstatePrototype. As with a shared prototype for methods, to make this work, we also introduce a separate state to baseRef weakmap, so the accessor can get the correctbaseReffrom itsthis, which is the empty state instance itself.See also
#7289
#6693
#7138
To get the benefit of this PR, more exoClasses will need stateShape metaData. See #7445
Please review while hiding whitespace differences.