refactor(swingset-liveslots): stateShape causes accessor sharing #7286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a kind is provided with a
stateShape
, we know exactly what the names are for all of thestate
fields across all instances. For that case, it is wasteful to create accessor properties per instance. So instead, when there is astateShape
, this PR will instead install similar accessors on a sharedstatePrototype
object. Eachstate
object is them a frozen empty object that inherits from thatstatePrototype
. As with a shared prototype for methods, to make this work, we also introduce a separatestateToInnerSelf
weakmap, so the accessor can get the correctinnerSelf
from itsthis
, which is the empty state instance itself.See also
#7289
#6693
#7138