Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilizing changes #1856

Merged
merged 14 commits into from
Nov 23, 2023
Merged

Stabilizing changes #1856

merged 14 commits into from
Nov 23, 2023

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Nov 21, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1856 (7fe347f) into develop (f2ad0f6) will increase coverage by 0.44%.
Report is 4 commits behind head on develop.
The diff coverage is 93.53%.

❗ Current head 7fe347f differs from pull request most recent head e581b68. Consider uploading reports for the commit e581b68 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1856      +/-   ##
===========================================
+ Coverage    84.01%   84.45%   +0.44%     
===========================================
  Files          290      290              
  Lines        14125    14101      -24     
  Branches       193      193              
===========================================
+ Hits         11867    11909      +42     
+ Misses        2125     2059      -66     
  Partials       133      133              
Flag Coverage Δ
Dispatcher 92.44% <100.00%> (+0.21%) ⬆️
Functional_Tests 51.70% <56.49%> (-0.05%) ⬇️
SDK 79.28% <92.19%> (+0.89%) ⬆️
UI_Backend 85.07% <95.55%> (+0.02%) ⬆️
UI_Frontend 73.43% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review November 23, 2023 14:16
@kessler-frost kessler-frost requested review from a team as code owners November 23, 2023 14:16
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@AlejandroEsquivel AlejandroEsquivel merged commit 0e67dfa into develop Nov 23, 2023
11 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the stabilizing-changes branch November 23, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants