-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose programmatic equivalent of CLI commands #1854
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1854 +/- ##
===========================================
+ Coverage 83.74% 83.80% +0.06%
===========================================
Files 291 293 +2
Lines 14316 14363 +47
Branches 195 195
===========================================
+ Hits 11989 12037 +48
+ Misses 2193 2192 -1
Partials 134 134
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtg @araghukas few documentation asks. Can you expose these in the docs API folder please?
and also test 🙏
@sriranjanivenkatesan can we pick this up and add it in the docs website please in API section? |
Quick question @araghukas -- with this approach, does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of directly importing server-side code, would something like subprocess.run(["covalent", "start"])
work?
@cjao Yes it does introduce a |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Marking ready for review since the added tests are indeed passing now ( Test failures now are due to UI backend tests... Is this expected @kessler-frost? |
Yep, I have fixed them in this PR: #1856, @AlejandroEsquivel will merge it soon, then we can merge this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing approval for now, needs some discussion.
for more information, see https://pre-commit.ci
@araghukas just checked this in google colab with latest pre-release, does not seem to be working 👀 |
Implements feature requested in #1853
edit: UX updated to