Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1785 Added covalent version attribute to Remote Executors #1802

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix: #1785 Added covalent version attribute to Remote Executors #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc35786
Fix: #1785 Added covalent version attribute to Remote Executors
maskboyAvi Oct 4, 2023
fef0c8e
Updated Changelog.md
maskboyAvi Oct 4, 2023
a714803
Update #!785 Set the default value of covalent_version to Empty
maskboyAvi Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Added covalent version attribute to Remote Executors
- Removed unassigned variable names
- Contributing guidelines steps for installing for the first time
- Updated gitignore to ignore yarn files and folders for latest version of yarn
Expand All @@ -19,7 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Changed `actions/checkout@v3` to `actions/checkout@v4` in CI
- Dependabot update to npm in changelog action
- Update tough-cookie to 4.1.3 version
- Added rich support to cli for better printing statements.
- Added rich support to cli for better printing statements.
- Changed semver from 5.7.1 to 5.7.2 in package.json
- Updated word-wrap to 1.2.4 version

Expand Down Expand Up @@ -53,7 +54,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Co-authored-by: Prasanna Venkatesh <[email protected]>
- FilipBolt <[email protected]>


### Fixed

- Formatted executor block under Qelectron job details to handle any class-type values
Expand Down Expand Up @@ -87,7 +87,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Docs

- Fix autodoc for SSH, Slurm, AWS Braket, AWS Lambda, AWS EC2, AWS Batch, Google Batch
- Fix autodoc for SSH, Slurm, AWS Braket, AWS Lambda, AWS EC2, AWS Batch, Google Batch
- Updated documentation links in README
- Added tutorial for redispatching workflows with Streamlit

Expand Down
3 changes: 3 additions & 0 deletions covalent/executor/executor_plugins/remote_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"poll_freq": 15,
"remote_cache": ".cache/covalent",
"credentials_file": "",
"covalent_version": "",
}


Expand All @@ -58,13 +59,15 @@ def __init__(
poll_freq: int = 15,
remote_cache: str = "",
credentials_file: str = "",
covalent_version: str = "",
**kwargs,
) -> None:
super().__init__(**kwargs)

self.poll_freq = poll_freq
self.remote_cache = remote_cache
self.credentials_file = credentials_file
self.covalent_version = covalent_version

@abstractmethod
async def _validate_credentials(self) -> bool:
Expand Down
Loading