Fix: #1785 Added covalent version attribute to Remote Executors #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kessler-frost
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Thanks @maskboyAvi ! Mostly looks good, just small comments.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1802 +/- ##
===========================================
- Coverage 80.08% 78.16% -1.93%
===========================================
Files 231 116 -115
Lines 10179 6960 -3219
Branches 193 0 -193
===========================================
- Hits 8152 5440 -2712
+ Misses 1894 1520 -374
+ Partials 133 0 -133
*This pull request uses carry forward flags. Click here to find out more. |
|
@kessler-frost I have made the requested changes. Please have a look. |
kessler-frost
approved these changes
Oct 4, 2023
|
Thanks @maskboyAvi ! |
kessler-frost
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1785
Added covalent version attribute to remote_executor.py