Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action bar #626

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Action bar #626

merged 9 commits into from
Jun 14, 2024

Conversation

rahulkgupta
Copy link
Collaborator

@rahulkgupta rahulkgupta commented Jun 12, 2024 •
edited by kfarr
Loading

  • removed AddLayerButton
  • Using event emitting
    Screenshot 2024-06-12 at 2 26 53 PM

TODO

  • fully delete AddLayerButton files
  • properly design these buttons. will need help here
    • need icons
    • need to figure out CSS ("selected")
    • need to figure out radio functionality.
  • when calling this.cursor.pause need some way to remove the little 3-axis thing
  • when clicking add we need to bring back the 3-axis thing to know where we are adding (out of scope. moved to use a "drop cursor" with add entity panel #630)

@rahulkgupta rahulkgupta requested a review from kfarr June 12, 2024 21:45
@rahulkgupta rahulkgupta changed the title Action bar [wip] Action bar Jun 13, 2024
rahulkgupta
rahulkgupta commented Jun 13, 2024
View reviewed changes
Copy link
Collaborator Author

@rahulkgupta rahulkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respond to comments

src/editor/index.js Show resolved Hide resolved
src/editor/components/components/ActionBar/ActionBar.module.scss Outdated Show resolved Hide resolved
@vincentfretin vincentfretin mentioned this pull request Jun 14, 2024
Closed
@kfarr kfarr merged commit d007458 into main Jun 14, 2024
1 check passed
@kfarr kfarr deleted the action-bar branch June 14, 2024 15:45
@vincentfretin vincentfretin changed the title [wip] Action bar Action bar Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentfretin vincentfretin vincentfretin left review comments

@kfarr kfarr Awaiting requested review from kfarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulkgupta @vincentfretin @kfarr