Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a basic arrow / hand toolbar #615

Closed
kfarr opened this issue Jun 11, 2024 · 4 comments
Closed

create a basic arrow / hand toolbar #615

kfarr opened this issue Jun 11, 2024 · 4 comments
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Jun 11, 2024

example UI:
Image

current behavior is arrow, and is default
new behavior is hand

  • when selected the cursor turns into an open hand to indicate grabbing
  • in this mode the raycaster is off, a user cannot select items

implementation thoughts:

  • might be implemented in EditorControls.js
  • keyboard shortcut "q" for hand mode? (since "w" is current keyboard shortcut for select / move; "e" is select / rotate; etc)
@kfarr kfarr converted this from a draft issue Jun 11, 2024
@kfarr kfarr moved this from To Do - Soon to To Do - High Prio in 3DStreet Dev Tracking Jun 11, 2024
@vincentfretin
Copy link
Collaborator

Not sure if that's really related to EditorControls, but better to not add more changes to it if you can avoid it. It's pending an update aframevr/aframe-inspector#687

@kfarr
Copy link
Collaborator Author

kfarr commented Jun 11, 2024

How to make this work:

  • create a new "actionbar" component that has radio button (radiogroup) logic to allow only pressing one at a time -- this is a new component that will live in components/components/ActionBar/
  • src/editor/components/components/ActionBar/ActionBar.component.jsx
  • src/editor/components/components/ActionBar/ActionBar.component.scss
  • disable raycaster effectively makes this work -- this logic should live in the actionbar. In the index.js file search for "cursor" cursor.pause()

Then to integrate this new component into Main.js

@kfarr kfarr assigned rahulkgupta and unassigned vincentfretin and kfarr Jun 11, 2024
@rahulkgupta rahulkgupta moved this from To Do - High Prio to In progress in 3DStreet Dev Tracking Jun 12, 2024
@vincentfretin
Copy link
Collaborator

PR worked on is #626

@vincentfretin vincentfretin moved this from In progress to For Review in 3DStreet Dev Tracking Jun 14, 2024
@kfarr kfarr moved this from For Review to Done in 3DStreet Dev Tracking Jun 14, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented Jun 14, 2024

closed by #626

@kfarr kfarr closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants