Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator usability epic v1 #395

Merged
merged 72 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
30c4cd0
add environment option color
Algorush Oct 5, 2023
f07eb4e
change roughness for all surfaces
Algorush Oct 26, 2023
4ebbcfe
add self-driving car variant
Algorush Oct 26, 2023
f5a746e
Bump browserify-sign from 4.2.1 to 4.2.2
dependabot[bot] Oct 27, 2023
c5739ab
Merge pull request #391 from 3DStreet/increase-roughness-surfaces
kfarr Nov 1, 2023
e60dc51
update assets submodule for new sky assets
kfarr Nov 1, 2023
494fe3b
add new sky support
kfarr Nov 1, 2023
2eacccb
add shadow support to assets and day preset
kfarr Nov 2, 2023
8c40c30
box geometry for rails + actual track gauges
kfarr Nov 2, 2023
70fc022
add dirt box to bottom of street
kfarr Nov 2, 2023
fa8a2c0
fine tune environment settings
kfarr Nov 2, 2023
ca33935
add character shadows
kfarr Nov 2, 2023
0958bbb
only set x position on segmentParent
kfarr Nov 2, 2023
ca89b15
remove positionX
kfarr Nov 2, 2023
0afbc14
Update segment and ground display names
kfarr Nov 2, 2023
9e190c0
delete the last positionX
Algorush Nov 3, 2023
bcf6fff
updating data-layer-name (display name)
kfarr Nov 3, 2023
41b1c03
add and fix elevation support for segments
Algorush Nov 4, 2023
4e116f5
Merge branch 'new-street-parser-structure' of https://github.com/3DSt…
Algorush Nov 4, 2023
07b1c40
fix car animation
Algorush Nov 5, 2023
7a8520d
add global animated to see car movement
kfarr Nov 6, 2023
243ba8e
Merge pull request #399 from 3DStreet/fix-car-animation
kfarr Nov 6, 2023
0786799
Merge branch 'creator-usability-epic-v1' into self-driving-segment
kfarr Nov 6, 2023
db8388c
fix merge mistake
kfarr Nov 6, 2023
3b1f82d
update to latest assets
kfarr Nov 6, 2023
d5103e7
Merge pull request #392 from 3DStreet/self-driving-segment
kfarr Nov 6, 2023
3b3e9e8
Revert "add and fix elevation support for segments"
kfarr Nov 6, 2023
013584c
Merge branch 'creator-usability-epic-v1' into new-street-parser-struc…
kfarr Nov 6, 2023
13aaf06
Merge pull request #397 from 3DStreet/new-street-parser-structure
kfarr Nov 6, 2023
f277bf9
reduce default street length, animated by default
kfarr Nov 7, 2023
49516ed
load animated rigged models in assets
kfarr Nov 7, 2023
e7e5e5f
use geometry width for making boxes
kfarr Nov 7, 2023
861dffc
remove scaleX and defaultWidths
kfarr Nov 7, 2023
cd3cf80
clarify if statement comment
kfarr Nov 7, 2023
fac1ab5
Merge pull request #401 from 3DStreet/try-making-selection-boxes
kfarr Nov 7, 2023
06f377f
improve building and block display names
kfarr Nov 7, 2023
974d5ea
add shadow to self driving car
kfarr Nov 7, 2023
2f15236
add ground name
kfarr Nov 7, 2023
32c0b67
v1 of working ocean
kfarr Nov 7, 2023
f67a710
wobbly ocean!
kfarr Nov 7, 2023
d467f14
fix elevation level support
Algorush Nov 8, 2023
5ab4a89
Merge branch 'creator-usability-epic-v1' into environment-color
kfarr Nov 9, 2023
5f80867
fix merge, ensure sky visible for relevant presets
kfarr Nov 9, 2023
0826fd8
Merge pull request #405 from 3DStreet/environment-color
kfarr Nov 9, 2023
39024d8
dont show helpers in scnreenshot
Algorush Nov 11, 2023
a129e35
update ocean component: add ocean-box
kfarr Nov 11, 2023
f0bd1b4
refactor showGround & use ocean for waterfront
kfarr Nov 11, 2023
251b4a0
remove legacy createGroundArray and test
kfarr Nov 11, 2023
fa3eb57
rename ocean-plane.js to ocean.js
kfarr Nov 11, 2023
913bf1e
support 6 of 9 block types
kfarr Nov 11, 2023
883f0c6
add support for arcade and compound-wall
kfarr Nov 12, 2023
cdd47c7
Merge branch 'creator-usability-epic-v1' into ocean-experiments
kfarr Nov 12, 2023
be8b997
Merge pull request #404 from 3DStreet/ocean-experiments
kfarr Nov 12, 2023
5f3d267
add title and logo to screenshot
Algorush Nov 12, 2023
5763cef
take logo for screenshot from svg logo
Algorush Nov 15, 2023
34ad27b
hide also cursor-teleport in screenshot
Algorush Nov 16, 2023
4c6dac4
add more randomly placed elements
Algorush Nov 22, 2023
7677cf8
use new function to generate screenshot to img element
kfarr Nov 24, 2023
afe95d8
increase size of logo
kfarr Nov 24, 2023
33b1371
Merge pull request #409 from 3DStreet/title-and-logo-in-screenshot
kfarr Nov 24, 2023
588394c
Merge pull request #413 from 3DStreet/more-randomly-placed-objects
kfarr Nov 24, 2023
a0ccf88
Merge pull request #393 from 3DStreet/dependabot/npm_and_yarn/browser…
kfarr Nov 24, 2023
79efd0a
fix for legacy scene support
kfarr Nov 30, 2023
236d5d2
remove animation by default
kfarr Nov 30, 2023
754c8d6
change street default length to 60 meters
kfarr Nov 30, 2023
49713ba
version bump and dist bump
kfarr Nov 30, 2023
f90fb14
Merge branch 'main' into creator-usability-epic-v1
kfarr Nov 30, 2023
ef3afcc
use default a-frame enter xr / ar UI for 1.5
kfarr Nov 30, 2023
80791f2
update submodule
kfarr Nov 30, 2023
369171d
update release checklist
kfarr Nov 30, 2023
3b91c88
dist bump
kfarr Nov 30, 2023
2fe79f1
remove extraneous logging
kfarr Nov 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,20 @@
We welcome community contributions to 3DStreet.

## Release checklist for this repo:
- Bump the version on package.json & package-lock.json (for example from 0.4.1 to 0.4.2)
- Update CHANGELOG.md with "Major improvement" changes summary (low level commits will be automatically generated by github in a later step) you can see notes of changes since last release on [this view](https://github.com/3DStreet/3dstreet/releases/tag/0.4.1)
- After all testing is done and things work well enough for a release.
- Bump the version on package.json & package-lock.json (for example from 0.4.2 to 0.4.4)
- Re-run npm run dist (rerun the build, it hardcodes the version into global var used for console log)
- Commit this all to the repo
- Create a new release here: https://github.com/3DStreet/3dstreet/releases/new. Choose a tag, type in the new version such as "0.4.2" and for the title simply use the new version such as "0.4.2". Click "generate release notes." Copy and paste the "Major improvements" from the above summary above the generated release notes below.
- Use command line to create new tag for new version `git tag 0.4.4` and `git push --tags`
- Create a new release here: https://github.com/3DStreet/3dstreet/releases/new. Choose the tag you just created. (If needed for the title simply use the new version such as "0.4.4")
- Click to automatically "generate release notes." Consider summarizing a few key changes to put at the top.
- Use those summaries to update CHANGELOG.md in this repo with "Major improvement" changes summary and link to the new release for detailed changes
- Update https://www.3dstreet.org/docs/development/releases/ with summary of major improvements and linking back to the new release on github.
- Then to run npm publish after all github version stuff works

## Updating assets submodule:
- from the repo's root directory run `git submodule update --remote` to update the assets submodule

## Contribution Instructions
* fork the repo
* make your contribution
Expand Down
2 changes: 1 addition & 1 deletion assets
4 changes: 2 additions & 2 deletions dist/aframe-street-component.js

Large diffs are not rendered by default.

35 changes: 11 additions & 24 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html>
<head>
<!-- aframe -->
<script src="https://aframe.io/releases/1.4.2/aframe.min.js"></script>
<script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script>

<!-- 3dstreet -->
<script src="./dist/aframe-street-component.js"></script>
Expand All @@ -14,7 +14,7 @@
<script src="./src/json-utils.js"></script>

<!-- ocean -->
<script src="./src/components/ocean-plane.js"></script>
<script src="./src/components/ocean.js"></script>

<!-- vr teleport controls -->
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/aframe-blink-controls.min.js"></script>
Expand Down Expand Up @@ -74,19 +74,16 @@
<li onclick="inputStreetmix()"> <a class="load" href="#"> <span> Load Streetmix URL </span> <img src="ui_assets/streetmix-logo.svg"> </a></li>
<!-- <li onclick="inputJSON()"> <a class="load" href="#"> <span> Load JSON String </span> <img src="assets/ui_assets/upload-icon.svg"> </a></li> -->
<li><a class="load"> <label for="inputfile" style="display: inherit; align-items: center; cursor: pointer"> <input type="file" id="inputfile" style="display:none" accept=".js, .json, .txt"> <span> Load JSON File </span> <img src="ui_assets/upload-icon.svg"></label></a></li>
<li> <a id="custom-enter-vr-button" class="vr" href="#"> <span class="vr">Enter VR mode</span> <img src="ui_assets/vr.svg"> </a></li>
<li> <a id="custom-enter-ar-button" class="ar" href="#"> <span class="ar">Enter AR mode</span> <img src="ui_assets/ar.svg"> </a></li>
</ul>
</div>

<a-scene
vr-mode-ui="enterVRButton: #custom-enter-vr-button; enterARButton: #custom-enter-ar-button;"
vr-mode-ui-if-headset
renderer="colorManagement: true; physicallyCorrectLights: true;"
inspector="url: //3dstreet.app/dist/3dstreet-editor.js"
notify
metadata
scene-title
reflection
>
<a-assets>
<!-- uncomment the line below to load assets from local github submodule -->
Expand All @@ -97,21 +94,21 @@
<street-assets categories="loud-bicycle sidewalk-props people vehicles vehicles-rigged buildings segment-textures segment-colors lane-separator stencils vehicles-transit dividers sky grounds"></street-assets>
</a-assets>

<a-entity id="street-container" data-layer-name="3D Street Layers" data-layer-show-children>
<a-entity id="default-street" street streetmix-loader set-loader-from-hash></a-entity>
</a-entity>

<a-entity id="reference-layers" data-layer-name="Reference Layers" data-layer-show-children></a-entity>

<a-entity id="environment" data-layer-name="Environment" street-environment="preset: day;"></a-entity>

<a-entity id="cameraRig" position="0 10 30" data-layer-name="Viewer" cursor-teleport="cameraRig: #cameraRig; cameraHead: #camera;" look-controls="reverseMouseDrag: true" wasd-controls="enabled: true">
<a-entity id="camera" camera="far: 1000" position="0 1.6 0" ></a-entity>
<a-entity id="leftHand" hand-controls="hand: left;" blink-controls="cameraRig: #cameraRig; teleportOrigin: #camera; rotateOnTeleport:false;"></a-entity>
<a-entity id="rightHand" hand-controls="hand: right" blink-controls="cameraRig: #cameraRig; teleportOrigin: #camera; rotateOnTeleport:false;"></a-entity>
<a-entity id="screenshot" class="no-pause" screentock visible="false"></a-entity>
</a-entity>

<a-entity id="environment" data-layer-name="Environment" street-environment="preset: day;"></a-entity>

<a-entity id="street-container" data-layer-name="3D Street Layers" data-layer-show-children>
<a-entity id="default-street" street streetmix-loader set-loader-from-hash></a-entity>
</a-entity>

<a-entity id="reference-layers" data-layer-name="Reference Layers" data-layer-show-children>

</a-scene>
</body>
<script>
Expand All @@ -131,16 +128,6 @@
document.getElementById('inputfile')
.addEventListener('change', fileJSON);

// only show VR button if headset connected
AFRAME.registerComponent('vr-mode-ui-if-headset', {
dependencies: ['vr-mode-ui'],
init: function () {
if (!AFRAME.utils.device.checkHeadsetConnected()) {
this.el.setAttribute('vr-mode-ui', 'enabled', false);
}
}
})

function buttonScreenshotTock() {
const screenshotEl = document.getElementById('screenshot');
screenshotEl.play(); // double check playing in case we're in editor mode
Expand Down
55 changes: 29 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "3dstreet",
"version": "0.4.2",
"version": "0.4.4",
"description": "Web-based 3D visualization of streets using A-Frame and WebXR",
"main": "dist/aframe-street-component.js",
"scripts": {
Expand Down
Loading
Loading