dont save street propery in JSON

[Algorush]

No description provided.

[netlify]

✅ Deploy Preview for 3dstreet-core-builds ready!

Name	Link
🔨 Latest commit	8fced24
🔍 Latest deploy log	https://app.netlify.com/sites/3dstreet-core-builds/deploys/654027d9bb15060008f660e2
😎 Deploy Preview	https://deploy-preview-355--3dstreet-core-builds.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kfarr]

Is this removeProps list used in saving new files? if we ignore all of street component properties, that means all those props cannot be changed by the user such as turning on/off showGround or showStriping or adjusting length? At the moment those can't be edited in realtime anyway, they have to be saved and then the scene reloaded for the scene to adjust and display the changes correctly. (or the street entity removed and a new one loaded in its place)

[Algorush]

Maybe I can add new boolean key 'loaded' to street property while saving JSON. And inside street component I can check it, if its equals true, then dont do nothing. And it will also help not reload all scene in other cases.
I will try to ignore only JSON property in street component. It will help in future

[Algorush]

I added commits, where I adjusted the work of the function that filters components. Now removing JSON string in street component works well. And now the size of the JSON file has decreased noticeably

[kfarr]

@Algorush I am confused by this -- why do we remove street parent?

const streetParent = this.el.querySelector('.street-parent');
const streetEl = streetmixParsers.processSegments(streetmixSegments.streetmixSegmentsFeet, data.showStriping, data.length, data.globalAnimated, data.showVehicles);
if (streetParent) {
  streetParent.remove();
}

[Algorush]

@Algorush I am confused by this -- why do we remove street parent?

const streetParent = this.el.querySelector('.street-parent');
const streetEl = streetmixParsers.processSegments(streetmixSegments.streetmixSegmentsFeet, data.showStriping, data.length, data.globalAnimated, data.showVehicles);
if (streetParent) {
  streetParent.remove();
}

Because .street-parent element is added here later in the code, inside the processSegments function:

3dstreet/src/aframe-streetmix-parsers.js

Line 708 in b3731c0

var streetParentEl = createCenteredStreetElement(segments);

I did this to avoid the case when the street component is applied several times to an element and then an issue occurs that the scene elements are added again. This case arise, for example, when changing the street parameters in the editor on the right panel. You can check it out in 3dstreet.app:

and now we can change the parameters of the street component. But yes, it was better to create a new issue for this, so as not to confuse

[kfarr]

To merge:

• remove unrelated parent entity changes in index.js from this PR
• merge in main to test
• test before / after for the other changes? (ie do x, y, z to generate extra JSON in current branch, do x, y, z with branch and observe something different?)

[kfarr]

Works as expected, and both old and new json files generated are able to be opened