Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old street elements before add new elements #389

Closed
Algorush opened this issue Oct 23, 2023 · 5 comments
Closed

remove old street elements before add new elements #389

Algorush opened this issue Oct 23, 2023 · 5 comments
Assignees

Comments

@Algorush
Copy link
Collaborator

Algorush commented Oct 23, 2023

in some cases, when adding a new scene, new street elements are added along with the old ones. Its better to clean up street and building elements before adding new ones.
I added the code to remove the .street-parent element in this PR: https://github.com/3DStreet/3dstreet/pull/355/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R39
Still need to do this for .buildings-parent element

@kfarr
Copy link
Collaborator

kfarr commented Oct 30, 2023

@Algorush can you provide more detailed instructions to reproduce is issue of "new street elements are added along with old ones?"

@Algorush
Copy link
Collaborator Author

Algorush commented Nov 1, 2023

For example, when changing the street component parameters for default-street element in the editor on the right panel.
image
I described it a earlier here and suggested a solution for this: #355 (comment)
not the best solution. Because every time you change the parameters of the street component, the entire scene will be reloaded. We can change parameters without reloading the scene, but this requires a little more time to implement

@Algorush
Copy link
Collaborator Author

Algorush commented Jan 8, 2024

Created PR to fix this: #448

@Algorush
Copy link
Collaborator Author

Algorush commented Jan 8, 2024

I noticed one thing with the checkbox in the right panel interface. The switch doesn't work when I click on an area outside of the small circle. I created an issue in 3DStreet-editror with a description: 3DStreet/3dstreet-editor#374

@kfarr
Copy link
Collaborator

kfarr commented Jan 15, 2024

#448

@kfarr kfarr closed this as completed Jan 15, 2024
@github-project-automation github-project-automation bot moved this from To Do - High Prio to Done in 3DStreet Dev Tracking Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants