Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix… #17

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix… #17

merged 3 commits into from
Aug 22, 2024

Conversation

sohaibimran-10xe
Copy link
Collaborator

@sohaibimran-10xe sohaibimran-10xe commented Aug 22, 2024 •
edited by taimur-10xe
Loading

Fixed

  • 2A internal crop (resolved the internal crop discrepancies with the RTL)
  • yuv reversal (now the pipeline does not reverse yuv for generating outputs to be compared with RTL
  • automated testing (moved all the testing scripts to another repo)
  • resolved the problem of ycbcr matrix, Cb and Cr were swapped with each other in case of BT.601 conversion standard)
  • AE computations converted to fixed-point operations
  • AWB computations corrected to resolve discrepancies with the RTL

Added

  • OSD block

@sohaibimran-10xe sohaibimran-10xe linked an issue Aug 22, 2024 that may be closed by this pull request
Add OSD (On-Screen Display) Module to ISP Pipeline #10
Closed
@sohaibimran-10xe
Copy link
Collaborator Author

Making issues against outdated document #18 and outdated Readme.

taimur-10xe
taimur-10xe approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@taimur-10xe taimur-10xe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes reviewed.

@sohaibimran-10xe sohaibimran-10xe merged commit 27345a8 into main Aug 22, 2024
1 check passed
@sohaibimran-10xe sohaibimran-10xe deleted the osd_yuv_autoscript branch August 22, 2024 14:41
talhaiqbal-10xe added a commit that referenced this pull request Aug 23, 2024
@talhaiqbal-10xe
Squashed commit of the following:
3e64f64 
commit 27345a8
Author: sohaibimran-10xe <[email protected]>
Date:   Thu Aug 22 19:38:31 2024 +0500

    Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix… (#17)

    * Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix fixed

    * fix osd configs and linting

    * fixed linting
sohaibimran-10xe pushed a commit that referenced this pull request Aug 26, 2024
@talhaiqbal-10xe
update readme, add repo flow diagram (#16)
c389bf1 
* update readme, add repo flow diagram

* update readme header

* Squashed commit of the following:

commit 27345a8
Author: sohaibimran-10xe <[email protected]>
Date:   Thu Aug 22 19:38:31 2024 +0500

    Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix… (#17)

    * Fixed 2A internal crop, automated testing, osd, yuv rev, ycbcr matrix fixed

    * fix osd configs and linting

    * fixed linting

* update readme headers and repo flow diagram

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taimur-10xe taimur-10xe taimur-10xe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OSD (On-Screen Display) Module to ISP Pipeline
2 participants
@sohaibimran-10xe @taimur-10xe