Fix for #133. Compatibility for custom IDbSet<> #134
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #133. Adds compatibility for custom `IDbSet<>` implementations by looking for an `ObjectQuery` property after trying the existing checks
|
Note this does build OK locally and all tests pass. The failed tests don't appear to be related to my commits, as the same tests were already failing in the master branch |
Fix for #14. Build cache key from a hash of the SQL that will be executed, along with any parameters and their values. With the previous expression-based method, parameters and their values were *not* being included in the cache key when `Include()` was used.
|
So, because I forgot to create a feature branch in my fork before submitting the first PR, this now includes fixes for both #133 and #14. And the AppVeyor build is now succeeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #133. Adds compatibility for custom
IDbSet<>implementations by looking for anObjectQueryproperty after trying the existing checks