Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

chore: config structure updated #60

Merged
merged 3 commits into from
Oct 25, 2023
Merged

chore: config structure updated #60

merged 3 commits into from
Oct 25, 2023

Conversation

MostPow3rful
Copy link
Contributor

Hi
in config file (.go & .yaml), User Structure Updated and renamed the pass_word to password
Also i passed the data to Config object in another way (i think it is better).

@MostPow3rful MostPow3rful requested a review from a team as a code owner October 25, 2023 13:36
Copy link
Member

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostPow3rful thank you.
just something to do:
use make fmt and push it again

and make sure it's good to use lowercase instead of snake case in yml!
I think for the password phrase it should be ok.
So, just do the make fmt

@kehiy kehiy changed the title Config Structure Updated chore:config structure updated Oct 25, 2023
@kehiy kehiy changed the title chore:config structure updated chore: config structure updated Oct 25, 2023
config/config.yaml Show resolved Hide resolved
@MostPow3rful
Copy link
Contributor Author

Hello @kehiy
i think the yaml naming style depends on project
for example, our project based on golang and golang's naming style is camelCase
so it's better to use camelCase in yaml

changed pass_word to password in comments
Copy link
Member

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostPow3rful Thanks.

@kehiy kehiy added the enhancement New feature or request label Oct 25, 2023
@kehiy kehiy merged commit 24609c3 into zurvan-lab:main Oct 25, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants