Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added new DLP Web Rule FileTypes #380

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Nov 18, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (111a60f) to head (0a3d113).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   68.34%   67.25%   -1.09%     
==========================================
  Files          82       82              
  Lines       16052    16072      +20     
==========================================
- Hits        10970    10810     -160     
- Misses       4347     4567     +220     
+ Partials      735      695      -40     
Files with missing lines Coverage Δ
zia/config.go 95.16% <100.00%> (+0.07%) ⬆️
zia/data_source_zia_url_categories.go 85.30% <100.00%> (ø)
zia/provider.go 93.45% <100.00%> (+0.07%) ⬆️
zia/resource_zia_auth_settings_urls.go 72.83% <100.00%> (ø)
...a_sandbox_behavioral_analysis_advanced_settings.go 62.69% <100.00%> (-2.39%) ⬇️
zia/resource_zia_security_policy_settings.go 70.10% <100.00%> (-2.07%) ⬇️
zia/resource_zia_url_categories.go 62.17% <100.00%> (-1.31%) ⬇️
zia/validator.go 32.68% <100.00%> (+2.08%) ⬆️

... and 10 files with indirect coverage changes

---- 🚨 Try these New Features:

@willguibr willguibr self-assigned this Nov 18, 2024
@willguibr willguibr added ⚙️ In development ⚙️ Under active development 🐛 type/bug :bug: type/bug labels Nov 18, 2024
@willguibr willguibr merged commit 5df1da5 into master Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 type/bug :bug: type/bug ⚙️ In development ⚙️ Under active development
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants