Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implemented IPv4 address validation for dest_address in the resource zia_firewall_filtering_rule #368

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

willguibr
Copy link
Member

fix: Implemented IPv4 address validation for dest_address in the resource zia_firewall_filtering_rule

@willguibr willguibr self-assigned this Aug 27, 2024
@willguibr willguibr added documentation Improvements or additions to documentation type/enhancement New feature or request 🐛 type/bug :bug: type/bug labels Aug 27, 2024
@willguibr willguibr added this to the v3.0.4 milestone Aug 27, 2024
@willguibr willguibr linked an issue Aug 27, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (986dbb2) to head (b322416).
Report is 1 commits behind head on master.

Files Patch % Lines
zia/validator.go 0.00% 30 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   68.51%   68.38%   -0.14%     
==========================================
  Files          82       82              
  Lines       13835    13865      +30     
==========================================
+ Hits         9479     9481       +2     
- Misses       3763     3792      +29     
+ Partials      593      592       -1     
Files Coverage Δ
zia/resource_zia_cloud_app_control_rules.go 3.63% <ø> (ø)
zia/resource_zia_firewall_filtering_rules.go 3.85% <ø> (ø)
zia/validator.go 18.06% <0.00%> (-1.50%) ⬇️

... and 1 file with indirect coverage changes

@willguibr willguibr merged commit 4656294 into master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 type/bug :bug: type/bug documentation Improvements or additions to documentation type/enhancement New feature or request
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

Firewall rule update error causes infinite retry
2 participants