Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added Validation for zia_forwarding_control_rule #366

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

willguibr
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 38.83495% with 63 lines in your changes missing coverage. Please review.

Project coverage is 68.45%. Comparing base (bfd3076) to head (de0a452).

Files Patch % Lines
zia/resource_zia_forwarding_control_rule.go 0.00% 30 Missing and 1 partial ⚠️
...zia_traffic_forwarding_gre_vip_recommended_list.go 56.00% 22 Missing ⚠️
zia/utils.go 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   67.72%   68.45%   +0.73%     
==========================================
  Files          82       82              
  Lines       13781    13835      +54     
==========================================
+ Hits         9333     9471     +138     
+ Misses       3908     3777     -131     
- Partials      540      587      +47     
Files Coverage Δ
zia/resource_zia_auth_settings_urls.go 74.57% <100.00%> (+1.84%) ⬆️
zia/resource_zia_security_policy_settings.go 71.01% <100.00%> (-1.30%) ⬇️
zia/resource_zia_url_categories.go 62.63% <100.00%> (-1.10%) ⬇️
zia/utils.go 45.45% <0.00%> (-2.74%) ⬇️
...zia_traffic_forwarding_gre_vip_recommended_list.go 66.66% <56.00%> (-0.78%) ⬇️
zia/resource_zia_forwarding_control_rule.go 2.57% <0.00%> (-2.01%) ⬇️

... and 5 files with indirect coverage changes

@willguibr willguibr self-assigned this Aug 19, 2024
@willguibr willguibr added documentation Improvements or additions to documentation ⚙️ In development ⚙️ Under active development 🐛 type/bug :bug: type/bug labels Aug 19, 2024
@willguibr willguibr added this to the v3.0.2 milestone Aug 19, 2024
@willguibr willguibr merged commit 986dbb2 into master Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 type/bug :bug: type/bug documentation Improvements or additions to documentation ⚙️ In development ⚙️ Under active development
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants