Use fluent to format a11y strings in reader #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For zotero build, add "reader.ftl" for localization - Remove redundant a11y strings from en-us.strings.js - Use document.l10n.formatValue for live messages and just data-l10n-id for aria labels - If document.l10n is undefined, nothing will be announced. That is until web library supports fluent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.l10n.formatValuefor live messages and justdata-l10n-idfor aria labelsdocument.l10nis undefined, nothing will be announced. That is until web library supports fluent.Per: #142 (comment)
Needs: zotero/zotero#4752