Rails 5 fix announcement service #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1) Rails 4 -> 5, parameters no longer inherit from HashWithIndifferentAccess 2) response.json no longer is valid in Rails 5. response's class in Rails 4 is ActionController::TestResponse in Rails 5, response's class is ActionDispatch::TestResponse 3) Starting Rails 5, responses will default to 204s unless specified otherwise. And status of 204 will return response.content_type as nil
…Controller::TestResponses
…onse in Rails 4. Rails 5 test responses are instances of ActionDispatch::TestResponse
…to rails-5---fix-announcement-service
Tooyosi
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were geared to get announcement_service.rb tests to pass. (Because of shared examples/specs were laid out on talk, it may be possible more tests have passed because of this).
Changes:
fetch,sliceetc. will no longer work.- We call
.to_hon params in order to be able to run hash methods.