Email verification #311
Merged
Email verification #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
approved these changes
Dec 5, 2023
| @@ -11,18 +11,18 @@ def show? | |||
|
|
|||
| def create? | |||
| if Array.wrap(record).compact.any? { |c| c.discussion.board.section == 'zooniverse' } | |||
| logged_in? && !locked? && writable? && of_posting_age? | |||
There was a problem hiding this comment.
Do we still want the of_posting_age? restriction now that we have confirmed?
| @@ -11,9 +11,9 @@ def show? | |||
|
|
|||
| def create? | |||
| if Array.wrap(record).compact.any? { |d| d.board.section == 'zooniverse' } | |||
| writable? && of_posting_age? | |||
| writable? && confirmed? && of_posting_age? | |||
There was a problem hiding this comment.
Do we still want the of_posting_age? restriction now that we have confirmed?
There was a problem hiding this comment.
Leaving this here because we can turn it off via deploy instead of removing the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Panoptes user table attribute
confirmed_at; a not-nullconfirmed_atattr indicates that the user has confirmed their email address. Includes checks of this attribute on all boards for the following action policies:Discussions: create
Comments: create, update, destroy
Conversations: index, show, create, destroy
Messages: index, show, create
This seems to follow the intentions of both the initial policies and the new restrictions. This could have been done at a higher level (closer to the application controller) where entire verbs would be blocked similarly to how bans are handled. However, this lacks the finer grain control of policies and introduces considerably more complexity in testing. This feels like a good compromise and is similar to how the account age requirement for posting was handled.
This PR requires the corresponding Panoptes PR to merge first. The couple of them will need some hands on testing on staging.