Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fe-root to FEM staging redirects #343

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add fe-root to FEM staging redirects #343

merged 1 commit into from
Apr 18, 2024

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Apr 15, 2024 •
edited
Loading

Complimentary to zooniverse/front-end-monorepo/pull/6032.

  • set fe-root staging uri and host
  • create location block for fe-root (aka app-root) assets
  • create location block for fe-root /users/ and /groups/ subpaths

@mcbouslog mcbouslog requested a review from zwolf April 15, 2024 14:36
@mcbouslog mcbouslog mentioned this pull request Apr 15, 2024
Merged
5 tasks
zwolf
zwolf approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the DNS entry for fe-root.preview is set up and this can merge before the FEM PR to get this all working.

@mcbouslog mcbouslog merged commit 05cc9f5 into master Apr 18, 2024
2 checks passed
@mcbouslog mcbouslog deleted the fe-root-staging branch April 18, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwolf zwolf zwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcbouslog @zwolf