Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5 Upgrade - Update restpack_serializer.gemspec #4

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Rails 5 Upgrade - Update restpack_serializer.gemspec #4

merged 5 commits into from
Aug 2, 2024

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Jul 5, 2024 •
edited
Loading

Changes

  • update activesupport dependencies to min rails 5
  • relax version constraints for factory_girl and sqlite3
  • replace protected_attributed with protected_attributes_continued. protected_attributes is no longer supported starting Rails 5 rails/rails@f4fbc03
  • Add ci/cd workflow to replace travis CI

TODO:

  • Once Talk is officially on Rails 5 on Prod, we can talk-api-version of restpack serializer to newest commit

@yuenmichelle1
Update restpack_serializer.gemspec
95a3132 
- update activesupport dependencies to min rails 5
- remove version requirements for factory_girl and sqlite3
- replace protected_attributed with protected_attributes_continued. protected_attributes is no longer supported starting Rails 5
@yuenmichelle1
Update .ruby-version
c7c2c28
@yuenmichelle1
Create run_tests_CI.yml
fb99299
@yuenmichelle1 yuenmichelle1 requested a review from Tooyosi July 5, 2024 19:15
@yuenmichelle1 yuenmichelle1 marked this pull request as draft July 5, 2024 19:19
@yuenmichelle1 yuenmichelle1 removed the request for review from Tooyosi July 5, 2024 19:19
@yuenmichelle1 yuenmichelle1 requested a review from Tooyosi July 5, 2024 19:42
@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review July 5, 2024 19:43
@yuenmichelle1 yuenmichelle1 merged commit 99089a6 into talk-api-version Aug 2, 2024
1 check passed
@yuenmichelle1 yuenmichelle1 mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tooyosi Tooyosi Awaiting requested review from Tooyosi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuenmichelle1