Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS Asset Loading #684

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix JS Asset Loading #684

merged 3 commits into from
Dec 10, 2024

Conversation

lcjohnso
Copy link
Member

@lcjohnso lcjohnso commented Dec 9, 2024 •
edited
Loading

Attempt to fix issue causing JS asset loading to 404.

Fixes #250
Reverts #225

Staging branch URL: https://pr-684.lab-preview.zooniverse.org/

To Review

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • Are the tests passing locally and on Travis?

@lcjohnso lcjohnso requested review from zwolf and mcbouslog December 10, 2024 19:33
mcbouslog
mcbouslog approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed staged branch organization edit page reloads and initial landing background image displays. 🚀

@lcjohnso lcjohnso merged commit 6b2eae1 into master Dec 10, 2024
4 checks passed
@lcjohnso lcjohnso deleted the wpconfig-path branch December 10, 2024 19:40
@lcjohnso lcjohnso mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

@zwolf zwolf Awaiting requested review from zwolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh on an organization page fails
2 participants
@lcjohnso @mcbouslog