Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zoo admins to view join token when querying user group #4338

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented May 30, 2024

Part of User Groups Feature:
Allow zooniverse admins to view join token when querying user group

  • Updated User Group Serializer include_join_token? check to check if current_user is_admin?

Pinging @mcbouslog so he is aware of this upcoming change.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 requested a review from zwolf May 30, 2024 03:11
@yuenmichelle1 yuenmichelle1 requested a review from Tooyosi May 30, 2024 15:38
Copy link
Contributor

@Tooyosi Tooyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuenmichelle1 yuenmichelle1 merged commit c1516c0 into master May 30, 2024
8 checks passed
@yuenmichelle1 yuenmichelle1 deleted the allow-zoo-admins-to-view-join_token-when-querying-user_group branch May 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants