Querying Memberships Fix: ensure distinct memberships when querying for ones own public memberships #4333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found while working on User Groups Features
Correspondence on issue found in this Slack thread here: https://zooniverse.slack.com/archives/C010QAPB67J/p1715888434468079?thread_ts=1715813389.436219&cid=C010QAPB67J
TL;DR; of the issue is that when doing a
GET
request to /memberships (either via/memberships?user_id=_user_group_id=_
or via/memberships/id
) to one's own public membership, response responds with duplicates.DELETE
becauseETag
headers will never match the precondition (due to response ofGET
request having dupes). Which results in412 Precondition Failed
error.Changes:
contains_exactly
rspec matching array method vsincludes
matchReview checklist
apiary.apib
file?