exclude subjects still linked to set_member_subject in subject_remover #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to: #4250 |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
yuenmichelle1
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Hey Toyosi!
Apologies for the late review. Overall this looks good. I think the biggest thing is
- the
TypeErroradded in remover.rb in order to get your tests to pass. I think the reason you've encountered this error in your specs lies possibly with how we are stubbing.
| def stub_discussions_request(subject_id) | ||
| stub_request(:get, discussions_url) | ||
| .with(query: { focus_id: subject_id, focus_type: 'Subject' }) | ||
| .to_return(status: 200, body: '[]', headers: {}) |
There was a problem hiding this comment.
I believe the reason you are getting (and catching) TypeErrors when reaching remover.rb's has_been_talked_about? (L68 of remover.rb) is because your stubbed response does not match that of the panoptes talk client.
Suggested change
| .to_return(status: 200, body: '[]', headers: {}) | |
| .to_return(status: 200, body: '{"discussions": []}', headers: {}) |
There was a problem hiding this comment.
Wow, thanks. I had no idea the response
lib/subjects/remover.rb
Outdated
| @@ -56,11 +59,19 @@ def has_been_collected_or_classified? | |||
| !orphan_subject | |||
| end | |||
|
|
|||
| def belongs_to_other_subject_set? | |||
| return false unless subject_set_id != nil | |||
There was a problem hiding this comment.
Suggested change
| return false unless subject_set_id != nil | |
| return false unless !subject_set_id.nil? |
yuenmichelle1
approved these changes
Mar 27, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change here.
Review checklist
apiary.apibfile?