Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting and updating stats_visibility on update and create #4260

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Oct 28, 2023

also adding error if stats_visibility is invalid to bypass Rails enum attribute validation that gives an ArgumentError.
Per:
https://stackoverflow.com/a/67090071

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 requested a review from zwolf October 29, 2023 17:17
@yuenmichelle1 yuenmichelle1 merged commit 99a3a0c into master Nov 6, 2023
7 checks passed
@yuenmichelle1 yuenmichelle1 deleted the allow-setting-stats_visibility-of-user_groups-on-create-and-update branch November 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant