set valid_email to true on user email change (#4292)

* set valid_email to true on user email change

* set valid_email to false before update_request in test

app/controllers/api/v1/users_controller.rb

@@ -52,6 +52,7 @@ def update
       super do |user|
         if user.email_changed?
           update_email_user_ids << user.id
+          user.update_attribute(:valid_email, true)
         end
       end
 

spec/controllers/api/v1/users_controller_spec.rb

@@ -482,6 +482,13 @@ def update_request
         expect(UserInfoChangedMailerWorker).to receive(:perform_async).with(user.id, "email")
       end
 
+      it "sets valid_email parameter to true" do
+        # updating the valid email to false before the request as it is set at true by default
+        user.update(valid_email: false)
+        update_request
+        expect(user.reload.valid_email).to be_truthy
+      end
+
       describe "with an email that already exists" do
         let(:put_operations) { {users: {email: User.where.not(id: user.id).first.email}} }
         it "doesn't send an email to the new address if user is not valid" do