Skip to content

Commit

Permalink
add comment on why installing certain version of rubygems-update
Browse files Browse the repository at this point in the history
  • Loading branch information
yuenmichelle1 committed Jan 2, 2024
1 parent 2b4a348 commit 9c85eeb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ADD ./Gemfile /rails_app/
ADD ./Gemfile.lock /rails_app/

RUN bundle config --global jobs `cat /proc/cpuinfo | grep processor | wc -l | xargs -I % expr % - 1`
# Newest versions of rubygems-update is not compatible with Ruby2.7 (Only compatible with Ruby 3+)
RUN gem i "rubygems-update:~>3.4.22" --no-document && update_rubygems
RUN bundle install --without development test

Expand Down
1 change: 1 addition & 0 deletions Dockerfile.dev
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ADD ./Gemfile /rails_app/
ADD ./Gemfile.lock /rails_app/

RUN bundle config --global jobs `cat /proc/cpuinfo | grep processor | wc -l | xargs -I % expr % - 1`
# Newest versions of rubygems-update is not compatible with Ruby2.7 (Only compatible with Ruby 3+)
RUN gem i "rubygems-update:~>3.4.22" --no-document && update_rubygems
RUN bundle install

Expand Down

0 comments on commit 9c85eeb

Please sign in to comment.