[issue-4351] add test cases to both UserInfoChangedMailerWorker and U…

…serInfoChangedMailer

spec/mailers/user_info_changed_mailer_spec.rb

@@ -21,10 +21,15 @@
     end
 
     context "email address was changed" do
-      let(:mail) { UserInfoChangedMailer.user_info_changed(user, "email")}
+      prev_email = '[email protected]'
+      let(:mail) { UserInfoChangedMailer.user_info_changed(user, "email", prev_email)}
       it 'should have the correct subject' do
         expect(mail.subject).to eq("Your Zooniverse email address has been changed")
       end
+
+      it 'should notify the previous mail' do
+        expect(mail.to).to include(prev_email)
+      end
     end
   end
 end

spec/workers/user_info_changed_mailer_worker_spec.rb

@@ -4,8 +4,17 @@
   let(:project) { create(:project) }
   let(:user) { create(:user) }
 
-  it 'should deliver the mail' do
-    expect{ subject.perform(user.id, "password") }.to change{ ActionMailer::Base.deliveries.count }.by(1)
+  context 'email delivery' do
+    it 'should deliver the mail' do
+      expect{ subject.perform(user.id, "password") }.to change{ ActionMailer::Base.deliveries.count }.by(1)
+    end
+
+    it 'should deliver to the right recipients' do
+      prev_pass = '[email protected]'
+      subject.perform(user.id, "email", prev_pass)
+      mail = ActionMailer::Base.deliveries.last
+      expect(mail.to).to eq([user.email, prev_pass])
+    end
   end
 
   context "without a user" do