Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paginate response from project preference fetch_settings #317

Merged
merged 2 commits into from
Aug 12, 2024
Merged

paginate response from project preference fetch_settings #317

merged 2 commits into from
Aug 12, 2024

Conversation

Tooyosi
Copy link
Contributor

@Tooyosi Tooyosi commented Aug 9, 2024

Make the response of project preference fetch settings to return paginated data

@lcjohnso lcjohnso force-pushed the paginate-project-fetch-settings-response branch from 172897e to 9e25080 Compare August 9, 2024 19:34
lcjohnso
lcjohnso approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@lcjohnso lcjohnso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I added some examples using the ResultPaginator to the User Guide entry for fetch_settings(), so now this is good to go.

@Tooyosi Tooyosi merged commit b5439dc into master Aug 12, 2024
4 checks passed
@Tooyosi Tooyosi deleted the paginate-project-fetch-settings-response branch August 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcjohnso lcjohnso lcjohnso approved these changes

@zwolf zwolf Awaiting requested review from zwolf

@yuenmichelle1 yuenmichelle1 Awaiting requested review from yuenmichelle1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tooyosi @lcjohnso