Remove max limit on dependency versions #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
approved these changes
Oct 4, 2023
zwolf
reviewed
Oct 4, 2023
| 'requests>=2.4.2,<2.29', | ||
| 'future>=0.16,<0.19', | ||
| 'python-magic>=0.4,<0.5', | ||
| 'requests>=2.4.2', |
There was a problem hiding this comment.
There's a 3.0 branch on the requests repo but no indication how soon it's coming or if that'll be a significant interface change. Could be worth including <3.0, but up to you.
There was a problem hiding this comment.
It looks like the requests 3.0 branch hasn't been touched since 2018ish, and I'm not sure whether any breaking changes would necessarily affect the Client or not even if/when released. My proposal: until it is demonstrated that some aspect of our Client is breaking with a newer version (whether thats 2.x or 3.x), I don't think it is worth the incompatibility for users wanting to download bleeding edge versions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Slack discussion (link to thread) with @adammcmaster confirmed that there was no specific issue dictating max limits on dependency versions (added in #129). To limit dependency version conflicts, I propose we remove these limits until a point where a specific max limit is required for any of the dependencies. We have received multiple reports (e.g., from Spyfish Aotearoa and Gravity Spy teams) of max version on
requestslibrary causing issues and incompatibilities.Closes #301 as that sort of bump would no longer be required.