Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add workflow import command #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

adammcmaster
Copy link
Contributor

Closes #73

@adammcmaster
Copy link
Contributor Author

@hughdickinson Could you look at IMPORTED_ATTRS and see if there's anything else I should be setting on the new workflow?

@hughdickinson
Copy link
Collaborator

Hi Adam. I checked the attributes that were set on the active workflow instance for the Clump Scout project. I got:

active
configuration
display_name
first_task
mobile_friendly
primary_language
retirement
tasks
links
id
steps
classifications_count
subjects_count
created_at
updated_at
finished_at
version
content_language
prioritized
grouped
pairwise
retired_set_member_subjects_count
href
aggregation
public_gold_standard
completeness

I'm not actually sure what most of them refer to and I assume that most of those will be set at some later stage. That said, in addition to what you already have you might want to add (optionally?) public_gold_standard, aggregation and content_language to those you already have?

@adammcmaster adammcmaster changed the title Add workflow import command [WIP] Add workflow import command Oct 25, 2019
@adammcmaster
Copy link
Contributor Author

Yeah, I think we'll want those to be included. They can't be edited in the Python client at the moment, so I'm going to put this on hold for now and include it in the 1.2 release instead (after the Python client is next updated).

@camallen
Copy link
Contributor

It would be better to use the API to clone a workflows and ensure all sub-resources are copied appropriately, zooniverse/Panoptes-Front-End#4733 (comment)
zooniverse/panoptes#2031 (comment)

It may be that workflow copying at the API isn't as fully featured as this implementation, however hearing these issues / use case would inform those features being added as we have similar support for whole projects, zooniverse/panoptes#2861

@adammcmaster
Copy link
Contributor Author

I'd be up for adding a copy command too, but I think it also makes sense to allow exporting/importing to/from a local file (the existing info command effectively already exports objects to YAML).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature to clone workflows between projects
4 participants