Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoptes.js: improve initial experimental auth #6527

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

shaunanoordin
Copy link
Member

PR Overview

This PR improves PR #6375 with the following updates:

  • Output & "error handling" for Event Listener functions:
    • addEventListener() no longer throws errors.
    • addEventListener() and removeEventListener() now returns true/false if the action succeeded/failed.
  • Documentation: the Sign In and Event Listener functions now have full documentation.
  • Code cleanup: unnecessary PJC reference code removed.
  • Dev Server/Dev Test Page:
    • Dev test page now displays success and/or error messages on the web page itself, so we don't need to look at the dev console to see wtf is happening.

Status

Merging into 6375.

@shaunanoordin shaunanoordin merged commit 3932e00 into remove-pjc-experiment-pt1 Dec 10, 2024
4 of 5 checks passed
@shaunanoordin shaunanoordin deleted the remove-pjc-experiment-pt2 branch December 10, 2024 14:04
@shaunanoordin shaunanoordin changed the title Panopte.js: improve initial experimental auth Panoptes.js: improve initial experimental auth Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant